forked from erikbern/ann-benchmarks
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elastic client update #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipecosta90
approved these changes
Jul 18, 2022
@GuyAv46 I noticed we're missing the elasticsearch requirement. Should we add |
@GuyAv46 I suggest we simplify the host port usage due to:
lets simply use something like:
Furthermore, starting to run the benchmark we reach timeouts after 1-2minutes:
so lets also try disable the index updates while we bulk load via |
92e2afa
to
e40f17c
Compare
DvirDukhan
reviewed
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding to Elasticsearch client its HNSW support. Also requiring certifications for connecting to the server (if you think its redundant, let me know)
for using elasticsearch client, pass username and password with
--user
,--auth
as before, or use environment variableELASTIC_PASSWORD
for passing certification file, use
ELASTIC_CA
environment variable.I'm assuming the we have a server with security settings. if not, this is redundant but it should work anyway.