Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable disable form options #6

Merged
merged 6 commits into from
Sep 9, 2021
Merged

Conversation

giuliaghisini
Copy link
Contributor

Is now possible to show or not some options in the column configuration from config:

config.settings["volto-editablefooter"] = {
    "options": { "socials": true, "newsletterSubscribe": true },
  };

Copy link
Member

@pnicolli pnicolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only suggested an indentation fix in the README but the rest looks fine

Co-authored-by: Piero Nicolli <[email protected]>
Copy link
Contributor

@nzambello nzambello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like it but I think the default values should be false, so it would be opt-in.
Socials are related to another addons, newsletter is not always present.

Copy link
Contributor

@nzambello nzambello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll make a major due to the default change, it needs to be addressed

@nzambello
Copy link
Contributor

@giuliaghisini se riesci documenta questa cosa come upgrade nel readme, così facciamo una major

@giuliaghisini
Copy link
Contributor Author

@giuliaghisini se riesci documenta questa cosa come upgrade nel readme, così facciamo una major

fatto

@giuliaghisini giuliaghisini merged commit 5bee3f2 into master Sep 9, 2021
@giuliaghisini giuliaghisini deleted the enable_options branch September 9, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants