-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable disable form options #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only suggested an indentation fix in the README but the rest looks fine
Co-authored-by: Piero Nicolli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I like it but I think the default values should be false, so it would be opt-in.
Socials are related to another addons, newsletter is not always present.
Co-authored-by: Nicola Zambello <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll make a major due to the default change, it needs to be addressed
@giuliaghisini se riesci documenta questa cosa come upgrade nel readme, così facciamo una major |
fatto |
Is now possible to show or not some options in the column configuration from config: