Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a11y for columns and edit content #10

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

Wagner3UB
Copy link
Contributor

  • 2 new regions created for landmarks ("Column selection" and "Edit column content")
  • The tabs now contain buttons instead of regular links
  • All buttons with a proper label inside the tabs
  • The "+" now is a button with a proper label

Note:
The aria-labels for Menu.Item and Button.Group are quite different because of a condition, with or without title. It's basically 2 default messages together if the title isn't set. I couldn't use props as I would like, using only one id because the condition doesn't allow me to translate the second part of the sentence.

aria-label={intl.formatMessage(messages.column) + ' ' + (idx + 1) + ' ' + (footerColumn.title ?? intl.formatMessage(messages.no_title))}

@Wagner3UB Wagner3UB self-assigned this Nov 14, 2023
@pnicolli pnicolli merged commit 95c1202 into master Nov 24, 2023
@pnicolli pnicolli deleted the us47109-a11y-footer branch November 24, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants