fix: a11y for columns and edit content #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
The aria-labels for Menu.Item and Button.Group are quite different because of a condition, with or without title. It's basically 2 default messages together if the title isn't set. I couldn't use props as I would like, using only one id because the condition doesn't allow me to translate the second part of the sentence.
aria-label={intl.formatMessage(messages.column) + ' ' + (idx + 1) + ' ' + (footerColumn.title ?? intl.formatMessage(messages.no_title))}