Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to bootstrap 4.0.0 #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update to bootstrap 4.0.0 #26

wants to merge 5 commits into from

Conversation

icemac
Copy link

@icemac icemac commented Jan 31, 2018

No description provided.

@luca-bellenghi
Copy link
Member

@icemac
Thank's for your pull request.
Can you please take a look at the failing test?

After that no problem to merge your PR

@icemac
Copy link
Author

icemac commented Apr 24, 2018

@luca-bellenghi Sorry for responding so late, I did not see your answer earlier. (Yes, I improved how I get GitHub notifications now.)
I fixed the test failure. But I already created a fork at https://github.com/gocept/js.bootstrap4 with Python 3 support, PyPI release and so on. I am not sure what's the best strategy now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icemac @luca-bellenghi