fix: no close search popup when redirecting to results page #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deodorhunter
approved these changes
Nov 26, 2024
deodorhunter
added a commit
that referenced
this pull request
Nov 26, 2024
Co-authored-by: Martina Bustacchini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quando si faceva una ricerca nel sito tramite la popup di ricerca che si apre cliccando sul pulsante presente nell'Header del sito, al submit, la popup si chiudeva e se il caricamento della pagina dei risultati richiedeva tempo, si rimaneva in "stallo" senza nessuna informazione evidente, sulla pagina da cui era partita la ricerca. Per l'utente era fuorviante perchè non era chiaro se la ricerca era partita o meno.
Ho evitato che la popup si chiudesse e ho aggiunto in overlay un loader.
Registrazione.schermo.2024-11-26.alle.12.00.11.mov
su v2 non è necessario portarla perchè ho gia fatto io