introduce autoflake #78
Conversation
autoflake complements flake8 for removing unused imports because flake8 just reports them and fails the pre-commit followed this reference to integrate via pre-commit: PyCQA/autoflake#62
|
@ibesso-rh: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ibesso-rh if |
|
@ibesso-rh Please add |
fixed. I ran pre-commit with autoflake included. |
done |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: myakove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Short description:
introduce autoflake pre-commit hook.
More details:
followed this reference to integrate via pre-commit:
PyCQA/autoflake#62
What this PR does / why we need it:
autoflake complements flake8 for removing unused imports
because flake8 just reports them and fails the pre-commit
Which issue(s) this PR fixes:
Special notes for reviewer:
Note that applying pre-commit on all files causes the following code to be modified:
class ValueMismatch(Exception):
"""
Raises when value doesn't match the class value
"""
the "pass" is redundant, and therefore, removed.
It's fine by me, but on another repo where I introduced autoflake that applied the same modification, you did not want this to be modified, so eventually that "pass" was replaced by actual effective code.
What do you want me to do?
Bug:
Release notes: