Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile and GitHub Actions to use Python 3.11 #85

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Update Dockerfile and GitHub Actions to use Python 3.11 #85

merged 2 commits into from
Jan 24, 2023

Conversation

ogajduse
Copy link
Member

@ogajduse ogajduse commented Jan 4, 2023

This PR updates cloudwash's Dockerfile to use Python 3.11. The python-311 image is built the same way as the UBI images, so the difference between them is minimal.

@ogajduse ogajduse force-pushed the update-dockerfile-py311 branch from 8207b4f to ca13e17 Compare January 4, 2023 13:02
@jyejare
Copy link
Collaborator

jyejare commented Jan 23, 2023

@ogajduse Looks Good! But I would suggest you to add python 3.11 checks in PR checks https://github.com/RedHatQE/cloudwash/blob/master/.github/workflows/pull_request.yml#L22 so that we start the installation before people start using it on py3.11 container.

@ogajduse
Copy link
Member Author

@ogajduse Looks Good! But I would suggest you to add python 3.11 checks in PR checks https://github.com/RedHatQE/cloudwash/blob/master/.github/workflows/pull_request.yml#L22 so that we start the installation before people start using it on py3.11 container.

addressed in 1198bf9.

@ogajduse ogajduse changed the title Update Dockerfile to use Python 3.11 Update Dockerfile and GitHub Actions to use Python 3.11 Jan 23, 2023
@jyejare
Copy link
Collaborator

jyejare commented Jan 23, 2023

I think we should test compatibility from python 3.9 to 3.11 . Not just 3.11

@ogajduse ogajduse force-pushed the update-dockerfile-py311 branch 2 times, most recently from 0b1184f to 4055614 Compare January 23, 2023 16:36
@ogajduse
Copy link
Member Author

I think we should test compatibility from python 3.9 to 3.11 . Not just 3.11

Updated. I have left release_to_pypi job to use 3.11 only.

@jyejare jyejare force-pushed the update-dockerfile-py311 branch from 4055614 to 26ad4f2 Compare January 24, 2023 08:03
@jyejare jyejare merged commit fb78112 into RedHatQE:master Jan 24, 2023
@ogajduse ogajduse deleted the update-dockerfile-py311 branch January 24, 2023 09:23
@ogajduse ogajduse mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogajduse @jyejare