Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Except VMs list from deleting and logging improvements #36

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Except VMs list from deleting and logging improvements #36

merged 1 commit into from
Jul 18, 2022

Conversation

jyejare
Copy link
Collaborator

@jyejare jyejare commented Jul 15, 2022 •
edited
Loading

Addresses #11 and logging improvements !

Improvements:

  • Now to stop the VM it does not required to follow the delete_vm setting from settings.yaml. In short, VM with any prepended text should be good to stop.
  • But the stop VM still follows the VM Running time settings.
  • For skip, the VM neither follows running time nor prepended text settings.

@jyejare
Copy link
Collaborator Author

jyejare commented Jul 18, 2022

The testing for this is completed locally and hence merging it now !

@jyejare jyejare merged commit 26d7ddb into master Jul 18, 2022
jyejare
jyejare commented Jul 18, 2022
View reviewed changes
Copy link
Collaborator Author

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jyejare jyejare deleted the except_vms branch October 31, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jyejare