-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vertical metrics on v3.001 #37
Comments
I've compared the metrics against the old fonts and figured out values which should retain the old leading and not lead to clipping. We currently have this situation: old value totals: new value totals: Proposed value totals: Basically, my proposed typo and hhea values are the same as the old. We adopt the new win asc and desc. To negate the consequences of the larger spacing caused by the new win values, we enable 'use typo metrics'. By doing this, we get the following Left: Proposed, MIddle: Old, Right:New Here's the proposed vertical metric values
To enable Use Typo Metrics in glyphsapp: Apologies I can't do this myself. I hope this helps you. Also use impallari/testing. The site caches fonts with the same name so to compare old and new fonts, you need to open the site again in a new tab/window. Kind regards and have a nice weekend, |
Thanks for bringing this to our attention and for the recommends @m4rc1e. We thought the issue was resolved but will give it another shot right away. |
Fixed. After reviewing the options, we are going with your recommendation @m4rc1e to see how that shakes out. |
Hey folks,
Sorry to disturb again. Ok, you've solved the clipping but the line spacing is now too loose. Since it's a Friday, I'll take a stab at this myself I think. Give me a few hours.
There is a flag in the OS/2 table called, 'Use_Typo_Metrics'. Enabling this flag will make Window's applications use the OS/2 typo asc and typo desc values, instead of the Win Asc and Win Desc. Using this flag is crucial in solving this problem. By not enabling this flag and changing the win asc and desc to the bbox, we get this problem.
This error is especially troublesome on the Monospace fonts because Sublime, Notepad, vim etc all don't have control over line-height/leading.
Cheers,
Marc
The text was updated successfully, but these errors were encountered: