Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Fixed specs with mandatory nil values + parser fixes #47

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Jan 16, 2020

TPINVTRY-824

  1. With fix of Ruby client nullable OpenAPITools/openapi-generator#4391 support for "nullable" causes that spec hashes must include <key> => nil when defined in parser.

  2. Fixed parser's Volume and Vm (orchestrations_stacks => orchestration_stack key)


@slemrmartin slemrmartin added the bug Something isn't working label Jan 16, 2020
@slemrmartin slemrmartin force-pushed the specs-and-relations-fix branch from 58ce994 to 90c1f85 Compare January 16, 2020 11:21
@miq-bot
Copy link
Collaborator

miq-bot commented Jan 16, 2020

Checked commits slemrmartin/topological_inventory-amazon@90c1f85~...7830c31 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 3 offenses detected

lib/topological_inventory/amazon/parser/vm.rb

lib/topological_inventory/amazon/parser/volume.rb

@gtanzillo gtanzillo requested a review from agrare January 17, 2020 18:54
@agrare agrare closed this Jan 20, 2020
@agrare agrare reopened this Jan 20, 2020
@agrare agrare merged commit fe4cd6d into RedHatInsights:master Jan 20, 2020
@agrare agrare assigned agrare and unassigned gtanzillo Jan 20, 2020
@slemrmartin slemrmartin deleted the specs-and-relations-fix branch January 20, 2020 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants