Remove default roles for apps not integrating with RBAC Lite #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to not make `system` and/or `platform_default` roles available or enforced for applications not integrating with the GA rollout of RBAC, we need to remove these roles from the seed files for the following apps: - ansible-automation - ansible-hub - catalog - remediations - sources - subscriptions Other apps not needing default roles are: - inventory - approval - sources - cost-management However at the time, we don't have default roles for those apps, so we don't need to take any action. There will be a PR added to the [RBAC app repo](https://github.com/RedHatInsights/insights-rbac/) in order to actually remove these roles from existing tenant schemas. This PR is to remove the roles from the seeds to prevent further creation of these default roles.
coderbydesign
added a commit
to coderbydesign/insights-rbac
that referenced
this pull request
Jan 29, 2020
In order to not make system and/or platform_default roles available or enforced for applications not integrating with the GA rollout of RBAC, we need to remove these roles from the seed files for the following apps: - ansible-automation - ansible-hub - catalog - remediations - sources - subscriptions Other apps not needing default roles are: - inventory - approval - sources - cost-management However at the time, we don't have default roles for those apps, so we don't need to take any action. A dependent PR has been added to the [RBAC config repo](RedHatInsights/rbac-config#17) to remove these roles from the seed files. That will need to be merged and rolled out before this PR can be merged.
coderbydesign
changed the title
astrozzc
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not make
systemand/orplatform_defaultroles available or enforcedfor applications not integrating with the GA rollout of RBAC, we need to remove
these roles from the seed files for the following apps:
Other apps not needing default roles are:
However at the time, we don't have default roles for those apps, so we don't need
to take any action.
There will be a PR added to the RBAC app repo
in order to actually remove these roles from existing tenant schemas.
This PR is to remove the roles from the seeds to prevent further creation of these
default roles.