feat(OCPADVISOR-71): Show upgrade risks table #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerreyes
reviewed
Apr 13, 2023
gkarat
force-pushed
the
ocpadvisor-71-upgrade-risks-tab
branch
from
fbdfd72 to
04c790b
Compare
ikerreyes
approved these changes
Apr 13, 2023
| ), | ||
| 'successful, alerts empty': () => { | ||
| const fixtures = upgradeRisksFixtures; | ||
| fixtures.upgrade_recommendation.upgrade_risks_predictors.alerts = []; |
There was a problem hiding this comment.
will not this modify the inner object for any subsequent uses? Don't we need a copy?
adonispuente
previously approved these changes
Apr 13, 2023
|
After the update for the mock server, I see every type of table that is on the mocks. Great job. LGTM |
Fewwy
approved these changes
Apr 14, 2023
| data?.upgrade_recommendation?.upgrade_risks_predictors || {}; | ||
|
|
||
| return ( | ||
| <TableComposable |
There was a problem hiding this comment.
When comparing to the mocks I see a few links/icons that arent shown here.
Your version:
mock version:
There was a problem hiding this comment.
good catch. there is no final agreement on the docs URL, so I'd wait for folks first to decide and then will add it via separate PR most probably
gkarat
pushed a commit
that referenced
this pull request
Apr 18, 2023
# [1.13.0](v1.12.1...v1.13.0) (2023-04-18) ### Features * **OCPADVISOR-71:** Show upgrade risks table ([#547](#547)) ([f9e3031](f9e3031))
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://issues.redhat.com/browse/OCPADVISOR-71.
Mocked at https://www.sketch.com/s/c5c07e06-f4a1-4c64-9cdf-8b12d8ac9ad5/a/25OY5ve.
This introduces the upgrade risks table that is shown under the "Upgrade risks" tab on the cluster details view.
v1/cluster/%id/upgrade-risks-prediction.How to test
The real endpoint will serve no data for real clusters, thus it is better to run this PR together with the mock service:
https://stage.foo.redhat.com:1337/beta/openshift/insights/advisor/clusters/%ID.00000003-eeee-eeee-eeee-000000000001must show firing alerts and cluster operators).Screenshots