fix(OCPADVISOR-59): Fix bad navigation between /clusters and /recommendations pages #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://issues.redhat.com/browse/OCPADVISOR-59. This is a temporary workaround to fix the navigation between /recommendations and /clusters via navigation menu.
gkarat
force-pushed
the
ocpadvisor-59-fix-loading-bug
branch
from
e7ffddb to
de7f5e6
Compare
gkarat
added a commit
that referenced
this pull request
Mar 9, 2023
Fixes https://issues.redhat.com/browse/OCPADVISOR-59. This is a temporary workaround to fix the navigation between /recommendations and /clusters via navigation menu.
gkarat
added a commit
that referenced
this pull request
Mar 9, 2023
Fixes https://issues.redhat.com/browse/OCPADVISOR-59. This is a temporary workaround to fix the navigation between /recommendations and /clusters via navigation menu.
gkarat
pushed a commit
that referenced
this pull request
Mar 9, 2023
## [1.11.2](v1.11.1...v1.11.2) (2023-03-09) ### Bug Fixes * **OCPADVISOR-59:** Fix not loading pages (part 2) ([#529](#529)) ([6b18f07](6b18f07))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/OCPADVISOR-59.
This is a temporary workaround to fix the navigation between /recommendations and /clusters via navigation menu. If users navigate between two pages by clicking on the nav menu, both pages will be continuously in the loading state and the tables will only render skeletons.
This has something to do with bad reducers resolution/data access. The API requests are fulfilled (in the network tab), however, not propagated to the appropriate reducers. Force re-render seems to be fixing this temporarily.
How to test
(see the video for steps)
Screencast.from.03-09-2023.10.56.44.AM.webm