fix(Tables): reduce re-renders; fix the incorrect data-ouia-safe attribute #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkarat
pushed a commit
that referenced
this pull request
Aug 15, 2022
## [1.6.3](v1.6.2...v1.6.3) (2022-08-15) ### Bug Fixes * **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([eec645b](eec645b))
|
🎉 This PR is included in version 1.6.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
gkarat
added a commit
that referenced
this pull request
Aug 16, 2022
gkarat
pushed a commit
that referenced
this pull request
Aug 16, 2022
## [1.6.3](v1.6.2...v1.6.3) (2022-08-15) ### Bug Fixes * **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([eec645b](eec645b))
gkarat
added a commit
that referenced
this pull request
Aug 17, 2022
gkarat
pushed a commit
that referenced
this pull request
Aug 17, 2022
## [1.6.3](v1.6.2...v1.6.3) (2022-08-15) ### Bug Fixes * **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([eec645b](eec645b))
gkarat
pushed a commit
that referenced
this pull request
Oct 14, 2022
## [1.6.2](v1.6.1...v1.6.2) (2022-10-14) ### Bug Fixes * **AffectedClustersTable:** replace impacted label OCPADVISOR-52 ([1c4acad](1c4acad)) * **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([c597913](c597913)) * **Tables:** set data-ouia-safe to true even when there is an error requesting API ([b5dfa5c](b5dfa5c))
gkarat
pushed a commit
that referenced
this pull request
Oct 17, 2022
## [1.6.2](v1.6.1...v1.6.2) (2022-10-17) ### Bug Fixes * **AffectedClustersTable:** replace impacted label OCPADVISOR-52 ([1c4acad](1c4acad)) * Fix cypress test coverage ([#434](#434)) ([3190ca0](3190ca0)) * **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([c597913](c597913)) * **Tables:** set data-ouia-safe to true even when there is an error requesting API ([b5dfa5c](b5dfa5c))
gkarat
pushed a commit
that referenced
this pull request
Oct 20, 2022
## [1.6.2](v1.6.1...v1.6.2) (2022-10-20) ### Bug Fixes * **AffectedClustersTable:** replace impacted label OCPADVISOR-52 ([1c4acad](1c4acad)) * Fix cypress test coverage ([#434](#434)) ([3190ca0](3190ca0)) * **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([c597913](c597913)) * **Tables:** set data-ouia-safe to true even when there is an error requesting API ([b5dfa5c](b5dfa5c))
gkarat
pushed a commit
that referenced
this pull request
Oct 21, 2022
# [1.7.0](v1.6.1...v1.7.0) (2022-10-21) ### Bug Fixes * **AffectedClustersTable:** replace impacted label OCPADVISOR-52 ([1c4acad](1c4acad)) * Fix cypress test coverage ([#434](#434)) ([3190ca0](3190ca0)) * **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([c597913](c597913)) * **Tables:** set data-ouia-safe to true even when there is an error requesting API ([b5dfa5c](b5dfa5c)) ### Features * **GitHubActions:** Add cypress yml config to run github actions ([#441](#441)) ([0547b14](0547b14))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues on https://issues.redhat.com/browse/OCPADVISOR-47: fixes the incorrect data-ouia-safe while tables are in the error empty state. Also, the PR rearranges
useEffects so that extra re-renders are avoided.