Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tables): filters edition modifies search params #195

Merged
merged 2 commits into from
Mar 28, 2022
Merged

feat(tables): filters edition modifies search params #195

merged 2 commits into from
Mar 28, 2022

Conversation

gkarat
Copy link
Collaborator

@gkarat gkarat commented Mar 28, 2022

@gkarat gkarat added the enhancement New feature or request label Mar 28, 2022
@gkarat gkarat self-assigned this Mar 28, 2022
@gkarat gkarat requested review from ikerreyes and Fewwy March 28, 2022 13:05
@gkarat gkarat marked this pull request as ready for review March 28, 2022 13:06
@codecov-commenter
Copy link

Codecov Report

Merging #195 (c71bf93) into master (5f263ce) will increase coverage by 0.55%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   76.19%   76.74%   +0.55%     
==========================================
  Files          27       27              
  Lines         903      929      +26     
  Branches      327      342      +15     
==========================================
+ Hits          688      713      +25     
- Misses        215      216       +1
Impacted Files Coverage Δ
src/Components/Common/Tables.js 85.21% <93.33%> (+1.21%) ⬆️
src/Components/RecsListTable/RecsListTable.js 74.61% <94.11%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93f0a4...c71bf93. Read the comment docs.

Fewwy
Fewwy approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@Fewwy Fewwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM

@gkarat gkarat merged commit 364501d into RedHatInsights:master Mar 28, 2022
gkarat pushed a commit that referenced this pull request Mar 28, 2022
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
59e383e 
# [1.1.0](v1.0.16...v1.1.0) (2022-03-28)

### Bug Fixes

* **tables:** revert the time-based refresh feature ([5961ef7](5961ef7))

### Features

* **Recommendations list table:** filters edition modifies search params ([#195](#195)) ([364501d](364501d))
@gkarat
Copy link
Collaborator Author

gkarat commented Mar 28, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikerreyes ikerreyes ikerreyes approved these changes

@Fewwy Fewwy Fewwy approved these changes

Assignees

@gkarat gkarat

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkarat @codecov-commenter @ikerreyes @Fewwy