feat(OCPADVISOR-72): Render upgrade risks banner #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #549 +/- ##
==========================================
+ Coverage 87.82% 88.14% +0.31%
==========================================
Files 31 32 +1
Lines 1265 1282 +17
Branches 486 499 +13
==========================================
+ Hits 1111 1130 +19
+ Misses 154 152 -2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gkarat
added a commit
that referenced
this pull request
Apr 19, 2023
gkarat
pushed a commit
that referenced
this pull request
Apr 19, 2023
# [1.14.0](v1.13.0...v1.14.0) (2023-04-19) ### Features * **OCPADVISOR-72:** Render banner to show status of upgrade risks ([#549](#549)) ([cdda357](cdda357))
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://issues.redhat.com/browse/OCPADVISOR-72.
Mocked at https://www.sketch.com/s/c5c07e06-f4a1-4c64-9cdf-8b12d8ac9ad5/a/8ylYyDw.
This makes the cluster view render the upgrade risks banner which indicates whether there are any upgrade risks for this cluster.
How to test
The same as for #547 (comment): try to run the PR together with the mock service. For different clusters (scenarios), you should get different results.
Screenshots
Has some risks
Has no risks/is a managed cluster
Service is down (503 status code)