Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix cypress test coverage #434

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

gkarat
Copy link
Collaborator

@gkarat gkarat commented Oct 14, 2022

This updates the cypress configs so that the coverage plugin can work again with component tests.

This updates the cypress configs so that the coverage plugin can work
again with component tests.
@gkarat gkarat added the bug Something isn't working label Oct 14, 2022
@gkarat gkarat requested a review from a team October 14, 2022 12:23
@gkarat gkarat self-assigned this Oct 14, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 0.00% // Head: 87.08% // Increases project coverage by +87.08% 🎉

Coverage data is based on head (0197962) compared to base (baf20ba).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #434       +/-   ##
===========================================
+ Coverage        0   87.08%   +87.08%     
===========================================
  Files           0       25       +25     
  Lines           0     1154     +1154     
  Branches        0      442      +442     
===========================================
+ Hits            0     1005     +1005     
- Misses          0      149      +149     
Impacted Files Coverage Δ
src/Services/Acks.js 90.00% <0.00%> (ø)
src/Components/Common/Tables.js 88.72% <0.00%> (ø)
src/Components/Breadcrumbs/index.js 100.00% <0.00%> (ø)
src/Services/Filters.js 100.00% <0.00%> (ø)
src/Utilities/Loaders.js 100.00% <0.00%> (ø)
src/Components/RecsListTable/RecsListTable.js 80.28% <0.00%> (ø)
src/Components/Modals/DisableRule.js 94.44% <0.00%> (ø)
src/Components/ClusterHeader/ClusterHeader.js 100.00% <0.00%> (ø)
src/Components/Recommendation/Recommendation.js 85.98% <0.00%> (ø)
src/Components/ClusterRules/ClusterRules.js 86.22% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gkarat gkarat merged commit 3190ca0 into RedHatInsights:master Oct 17, 2022
gkarat pushed a commit that referenced this pull request Oct 17, 2022
## [1.6.2](v1.6.1...v1.6.2) (2022-10-17)

### Bug Fixes

* **AffectedClustersTable:** replace impacted label OCPADVISOR-52 ([1c4acad](1c4acad))
* Fix cypress test coverage ([#434](#434)) ([3190ca0](3190ca0))
* **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([c597913](c597913))
* **Tables:** set data-ouia-safe to true even when there is an error requesting API ([b5dfa5c](b5dfa5c))
gkarat pushed a commit that referenced this pull request Oct 20, 2022
## [1.6.2](v1.6.1...v1.6.2) (2022-10-20)

### Bug Fixes

* **AffectedClustersTable:** replace impacted label OCPADVISOR-52 ([1c4acad](1c4acad))
* Fix cypress test coverage ([#434](#434)) ([3190ca0](3190ca0))
* **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([c597913](c597913))
* **Tables:** set data-ouia-safe to true even when there is an error requesting API ([b5dfa5c](b5dfa5c))
gkarat pushed a commit that referenced this pull request Oct 21, 2022
# [1.7.0](v1.6.1...v1.7.0) (2022-10-21)

### Bug Fixes

* **AffectedClustersTable:** replace impacted label OCPADVISOR-52 ([1c4acad](1c4acad))
* Fix cypress test coverage ([#434](#434)) ([3190ca0](3190ca0))
* **Tables:** reduce re-renders; fix the incorrect data-ouia-safe attribute ([#389](#389)) ([c597913](c597913))
* **Tables:** set data-ouia-safe to true even when there is an error requesting API ([b5dfa5c](b5dfa5c))

### Features

* **GitHubActions:** Add cypress yml config to run github actions ([#441](#441)) ([0547b14](0547b14))
@gkarat
Copy link
Collaborator Author

gkarat commented Oct 21, 2022

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants