fix(RHINENG-8615): Fix "View ${n} affected clusters" link missing (#728)

* chore: package-lock.json update * fix(RHINENG-8615): Pass ViewAffectedLink instead of showViewAffected Fixes https://issues.redhat.com/browse/RHINENG-8615.
RedHatInsights · Apr 9, 2024 · ea8be87 · ea8be87
1 parent b6d8be5
commit ea8be87
Show file tree

Hide file tree

Showing 3 changed files with 80 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/Components/RecsListTable/RecsListTable.cy.js b/src/Components/RecsListTable/RecsListTable.cy.js
@@ -53,6 +53,7 @@ import {
   removeAllChips,
   urlParamConvert,
   checkEmptyState,
+  TABLE_ROW,
 } from '@redhat-cloud-services/frontend-components-utilities';
 
 import { SORTING_ORDERS } from '../../../cypress/utils/globals';
@@ -256,6 +257,14 @@ describe('data', () => {
       _.filter(filterData(), (it) => it.impacted_clusters_count > 1)
     ).to.have.length.gte(1);
   });
+  it('at least one rule has no affecting clutsers', () => {
+    expect(
+      filterData({
+        impacting: ['None'],
+      }),
+      (it) => it.impacted_clusters_count === 0
+    ).to.have.length.gte(1);
+  });
   it('at least one recommendation in default list has resolution risk set to non 0 value', () => {
     expect(
       filterData().filter(
@@ -705,6 +714,29 @@ describe('successful non-empty recommendations list table', () => {
         .find('.ins-c-rule-details__risk-of-ch-label')
         .should('have.text', 'High');
     });
+
+    it('view affected link is present for rules affecting at least one cluster', () => {
+      cy.getRowByName(
+        'Super atomic nuclear cluster on the brink of the world destruction'
+      )
+        .find('[aria-label="Details"]')
+        .click();
+      cy.get(EXPANDABLES)
+        .first()
+        .contains(/View [\d\w,]* affected clusters/);
+    });
+
+    it('view affected link is missing for non-affecting rules', () => {
+      removeAllChips();
+      filterApply({
+        impacting: ['None'],
+      });
+      cy.get(TABLE_ROW).first().find('[aria-label="Details"]').click();
+      cy.get(EXPANDABLES)
+        .first()
+        .contains(/View [\d\w,]* affected clusters/)
+        .should('not.exist');
+    });
   });
 
   describe('enabling/disabling', () => {

diff --git a/src/Components/RecsListTable/RecsListTable.js b/src/Components/RecsListTable/RecsListTable.js
@@ -265,8 +265,20 @@ const RecsListTable = ({ query }) => {
                       product={AdvisorProduct.ocp}
                       rule={adjustOCPRule(value)}
                       isDetailsPage={false}
-                      showViewAffected
-                      linkComponent={Link}
+                      {...(value.impacted_clusters_count > 0
+                        ? {
+                            ViewAffectedLink: (
+                              <Link to={value.rule_id}>
+                                {intl.formatMessage(
+                                  messages.viewAffectedClusters,
+                                  {
+                                    clusters: value.impacted_clusters_count,
+                                  }
+                                )}
+                              </Link>
+                            ),
+                          }
+                        : {})}
                       {...(inRange(value?.resolution_risk, 1, 5) // resolution risk can be 0 (not defined for particular rule)
                         ? {
                             resolutionRisk: value?.resolution_risk,