Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings for smoke test run #205

Conversation

catastrophe-brandon
Copy link
Contributor

@catastrophe-brandon catastrophe-brandon commented Feb 12, 2020

To get the smoke tests to pick up the required settings from Jenkins we need to do the following:

  1. Merge this change into master
  2. Set up a PR with this change targeting stable. (We can incorporate this change into the existing PR for stable once we have it in master).

This is required because the groovy file with the change needs to be available in the rbac container when running the smoke tests.

@catastrophe-brandon catastrophe-brandon changed the base branch from master to stable February 12, 2020 15:56
@catastrophe-brandon catastrophe-brandon changed the base branch from stable to master February 12, 2020 18:08
Copy link
Contributor

@coderbydesign coderbydesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@wcmitchell wcmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@catastrophe-brandon
Copy link
Contributor Author

I'm not sure if we'll be able to merge this to master if we get approvals. I hate to ask, but will we need to temporarily disable checks to get it through?

@coderbydesign coderbydesign merged commit f64985f into RedHatInsights:master Feb 12, 2020
lpichler pushed a commit that referenced this pull request Nov 8, 2023
Add organization resource for subscriptions app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants