-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role access GET endpoint: /roles/<uuid>/access/ #198
Merged
coderbydesign
merged 3 commits into
RedHatInsights:master
from
coderbydesign:add-role-access-get-endpoint
Feb 11, 2020
Merged
Add role access GET endpoint: /roles/<uuid>/access/ #198
coderbydesign
merged 3 commits into
RedHatInsights:master
from
coderbydesign:add-role-access-get-endpoint
Feb 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support the front-end RBAC efforts, we're adding an endpoint which returns the serialized access objects for a given role. The response for a valid role will return a paginated payload such as: ``` { "meta": { "count": 2, "limit": 10, "offset": 0 }, "links": { "first": "/api/rbac/v1/roles/3ecac858-4f48-4393-a26b-914ba73477aa/access/?limit=10&offset=0", "next": null, "previous": null, "last": "/api/rbac/v1/roles/3ecac858-4f48-4393-a26b-914ba73477aa/access/?limit=10&offset=0" }, "data": [ { "permission": "inventory:*:*", "resourceDefinitions": [] }, { "permission": "ansible-automation:*:*", "resourceDefinitions": [] } ] } ``` The response for an invalid/non-existent role will return a 404.
astrozzc
reviewed
Feb 6, 2020
astrozzc
reviewed
Feb 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just have a small comment
astrozzc
approved these changes
Feb 7, 2020
wcmitchell
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lpichler
pushed a commit
that referenced
this pull request
Nov 8, 2023
Add OCP Advisor roles and permissions for qa env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the
GET
endpoint:/roles/<uuid>/access/
to the API. While the access objects are currently returned as a nested resource within/roles/<uuid>/
, the UI is requesting that we provide an explicit endpoint for retrieving access objects for a given role, in order to paginate and eventually filter on this data directly.The payload will look like:
And is represented in the openapi.json spec:

Currently there is no filtering on this endpoint, only pagination.