Add migration aimed at removing RBAC on RBAC roles #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, and tests failing. let me fix that. Left in some PDB statements |
Signed-off-by: Chris Mitchell <[email protected]>
Signed-off-by: Chris Mitchell <[email protected]>
wcmitchell
force-pushed
the
RonR_removal_migration
branch
from
bb778c1 to
b2e663a
Compare
| # if so, just delete the access object we know is RBAC, and leave the role | ||
| if non_rbac_permissions: | ||
| # this will still delete the resource definitions for the access object | ||
| access.delete() |
There was a problem hiding this comment.
This actually needs to be rbac_permission here, I believe?
Suggested change
| access.delete() | |
| rbac_permission.delete() |
There was a problem hiding this comment.
Yep, I think you're right. That's what I get for playing with naming just before submitting >_<
Comment on lines
26
to
28
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Just a nit, but we can probably do away with a few of these newlines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like it works from some local testing, but definitely needs a couple of extra eyes on it.
Signed-off-by: Chris Mitchell [email protected]