Shows error when proxy encounter exception #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbydesign
approved these changes
Jan 20, 2020
tests/management/group/test_view.py
Outdated
| 'source': 'principals' | ||
| }]}) | ||
| def test_add_group_principals_failure(self, mock_request): | ||
| """Test that adding a principal to a group returns successfully.""" |
There was a problem hiding this comment.
Probably want to update this doc comment to reflect failure?
There was a problem hiding this comment.
Good catch! Will update
When proxy returns error, it was not considered. e.g. when the threre is connection error, the program just shows 200 to customer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When proxy returns error, it was not considered. e.g. when the threre is connection
error, the program just shows 200 to customer.