-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHCLOUD-27273] Maintenance Endpoint to fix resourceDefinitions #1448
[RHCLOUD-27273] Maintenance Endpoint to fix resourceDefinitions #1448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for id in result: | ||
resource_definition = ResourceDefinition.objects.get(id=id[0]) | ||
resource_definition.attributeFilter["operation"] = "equal" | ||
resource_definition.save() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be a ton of these cases, so performance should be acceptable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did check our DB's for these cases and there were only 2 or 3 that would need a change.
BLOCKING: #1418
Link(s) to Jira
Description of Intent of Change(s)
The what, why and how.
This end point will correct any existing ResourceDefinitions with bad attributeFilters. In this case it's list values having an
equal
operation and string values having anin
operation.Local Testing
How can the feature be exercised?
How can the bug be exploited and fix confirmed?
Is any special local setup required?
Unit Tests cover the possible scenarios.
Checklist
Secure Coding Practices Checklist Link
Secure Coding Practices Checklist