Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-35963] - Added annotations for principals when filtering groups by exclude_use… #1387

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EvanCasey13
Copy link
Contributor

@EvanCasey13 EvanCasey13 commented Dec 13, 2024

…rname or username

Link(s) to Jira

(https://issues.redhat.com/browse/RHCLOUD-35963)

Description of Intent of Change(s)

Added annotations for principal count when filtering group using exclude_username or username query parameters

Local Testing

How can the feature be exercised?
How can the bug be exploited and fix confirmed?
Is any special local setup required?

Checklist

  • if API spec changes are required, is the spec updated?
  • are there any pre/post merge actions required? if so, document here.
  • are theses changes covered by unit tests?
  • if warranted, are documentation changes accounted for?
  • does this require migration changes?
    • if yes, are they backwards compatible?
  • is there known, direct impact to dependent teams/components?
    • if yes, how will this be handled?

Secure Coding Practices Checklist Link

Secure Coding Practices Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@EvanCasey13 EvanCasey13 changed the title Added annotations for principals when filtering groups by exclude_use… [RHCLOUD-35963] - Added annotations for principals when filtering groups by exclude_use… Dec 13, 2024
Copy link
Contributor

@astrozzc astrozzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I commented on the PR but can't find it 😅
LGTM, better to have one more to take a look

Copy link
Contributor

@vbelchio vbelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvanCasey13
Check some combinations of tests, for the username=<user> the principalCount is always showing 1 even when there are more users inside the groups in the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants