Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable v2 APIs by default (configurable) #1212

Merged

Conversation

coderbydesign
Copy link
Contributor

Link(s) to Jira

Description of Intent of Change(s)

By default, we'll disable v2 APIs, with the ability to enable them through deployment configuration in order to prevent access prior to full production availability and support.

In stage we'll also want to configure this to set it on via param.

Local Testing

Locally, you'll need to set your .env want to set V2_APIS_ENABLED=True in order to exercise v2 APIs locally.

Checklist

  • if API spec changes are required, is the spec updated?
  • are there any pre/post merge actions required? if so, document here.
  • are theses changes covered by unit tests?
  • if warranted, are documentation changes accounted for?
  • does this require migration changes?
    • if yes, are they backwards compatible?
  • is there known, direct impact to dependent teams/components?
    • if yes, how will this be handled?

Secure Coding Practices Checklist Link

Secure Coding Practices Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

By default, we'll disable v2 APIs, with the ability to enable them through deployment
configuration in order to prevent access prior to full production availability and support.

Locally, you'll need to set your `.env` want to set `V2_APIS_ENABLED=True` in order
to exercise v2 APIs locally.

In stage we'll also want to configure this to set it on via param.
Copy link
Contributor

@lpichler lpichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@coderbydesign
Copy link
Contributor Author

/retest

1 similar comment
@coderbydesign
Copy link
Contributor Author

/retest

@coderbydesign
Copy link
Contributor Author

/retest

2 similar comments
@coderbydesign
Copy link
Contributor Author

/retest

@vbelchio
Copy link
Contributor

vbelchio commented Oct 2, 2024

/retest

@coderbydesign coderbydesign merged commit d460883 into RedHatInsights:master Oct 3, 2024
10 checks passed
@coderbydesign coderbydesign deleted the disable-v2-apis-by-default branch October 3, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants