Don't create root workspace in database in migration tool #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbydesign
approved these changes
Aug 27, 2024
lpichler
force-pushed
the
dont_create_root_workspace_record_in_db
branch
from
26a3183 to
ec963a6
Compare
astrozzc
force-pushed
the
dont_create_root_workspace_record_in_db
branch
2 times, most recently
from
52f12cd to
c3060af
Compare
astrozzc
force-pushed
the
dont_create_root_workspace_record_in_db
branch
from
c3060af to
340740c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
existence of root workspace in RBAC doesn't have usage and it becomes prerequisite to enable dual writes
it adds complexity: it is need to create root workspace when new organisation needs to be created rbac
Name of root workspace could be determined from
org_idonly which simplifies code and reduces issues which be caused by existence/non-existence of root workspace