fix: reworked HTTP status code handling for 2xx and 3xx ranges (MWTELE-68, MWTELE-69) #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mocenas |
…E-68, MWTELE-69) This ensures any 2xx response is considered valid. The client now follows redirects (3xx range). JIRA: https://issues.redhat.com/browse/MWTELE-68 JIRA: https://issues.redhat.com/browse/MWTELE-69
jponge
force-pushed
the
bug/MWTELE-68-and-MWTELE-69
branch
from
db9b57c to
f58c195
Compare
jponge
commented
May 2, 2023
| ERROR_HTTP_SEND_INVALID_CONTENT_TYPE, | ||
| "Content type of payload is unsupported"); | ||
| } | ||
| case 5: |
There was a problem hiding this comment.
Note: I have deliberately kept multiple case label statements based on the original OpenAPI spec of the Go insights backend. These are not very clean switch constructs, but I wanted to keep track of the expected status codes.
There was a problem hiding this comment.
Why not defining an enum for each 'category': could be more readable WDYT ?
There was a problem hiding this comment.
Shouldn't we deal with 403 as maybe the subscription is no longer active or something like this ?
|
LGTM |
ehsavoie
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures any 2xx response is considered valid. The client now follows redirects (3xx range).
JIRA: https://issues.redhat.com/browse/MWTELE-68
JIRA: https://issues.redhat.com/browse/MWTELE-69