fixing issue ocurring when trying to open a jarUrl to compute a SHA if #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsavoie
force-pushed
the
jar_url_issue
branch
3 times, most recently
from
29b7bfe to
4d126dd
Compare
When trying to open a jarUrl to compute a SHA if the target archive is the jar itself and not an embedded archive then openStream will fail. So in that case we need to open a stream to a file URL and not a jarUrl. Signed-off-by: Emmanuel Hugonnet <[email protected]>
ehsavoie
force-pushed
the
jar_url_issue
branch
from
4d126dd to
3348c5a
Compare
jponge
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the target archive is the jar itself and not an embedded archive.