Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RHINENG-5449): add new prometheus metrics #1613

Merged
merged 3 commits into from
Feb 13, 2024
Merged

feat(RHINENG-5449): add new prometheus metrics #1613

merged 3 commits into from
Feb 13, 2024

Conversation

FabriciaDinizRH
Copy link
Contributor

@FabriciaDinizRH FabriciaDinizRH commented Feb 2, 2024 •
edited
Loading

Overview

This PR is being created to address RHINENG-5449.
This PR adds the following metrics to HBI: consumed_message_size, produced_message_size and produce_large_message_failure.

Since I'll be away, please feel free to merge commits with fixes if needed, so this PR can be merged as soon as possible.

PR Checklist

  • Keep PR title short, ideally under 72 characters
  • Descriptive comments provided in complex code blocks
  • Tests: validate optimal/expected output
  • Tests: validate exceptions and failure scenarios
  • Tests: edge cases
  • Recovers or fails gracefully during potential resource outages (e.g. DB, Kafka)
  • Uses type hinting, if convenient
  • Documentation, if this PR changes the way other services interact with host inventory
  • Links to related PRs

Secure Coding Practices Documentation Reference

You can find documentation on this checklist here.

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@FabriciaDinizRH FabriciaDinizRH force-pushed the add_prometheus_metrics branch 2 times, most recently from b0bc8f8 to e0f5855 Compare February 2, 2024 19:28
vkrizan
vkrizan reviewed Feb 6, 2024
View reviewed changes
app/queue/metrics.py Show resolved Hide resolved
app/queue/event_producer.py Outdated Show resolved Hide resolved
app/queue/event_producer.py Show resolved Hide resolved
@FabriciaDinizRH FabriciaDinizRH marked this pull request as ready for review February 13, 2024 01:40
@FabriciaDinizRH FabriciaDinizRH requested a review from a team as a code owner February 13, 2024 01:40
kruai
kruai reviewed Feb 13, 2024
View reviewed changes
app/queue/metrics.py Outdated Show resolved Hide resolved
@kruai kruai merged commit e682e88 into RedHatInsights:master Feb 13, 2024
3 of 4 checks passed
thearifismail pushed a commit to thearifismail/insights-host-inventory that referenced this pull request Feb 28, 2024
@FabriciaDinizRH @kruai @thearifismail
feat(RHINENG-5449): add new prometheus metrics (RedHatInsights#1613)
dad0284 
* feat(RHINENG-5449): add new prometheus metrics

* fix utf8 typos

* Fix typo

---------

Co-authored-by: Asa Price <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkrizan vkrizan vkrizan left review comments

@kruai kruai kruai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FabriciaDinizRH @kruai @vkrizan