Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update rails to 8.0.0 #2309

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

skateman
Copy link
Member

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@skateman skateman requested a review from a team as a code owner November 15, 2024 07:31
@skateman
Copy link
Member Author

Blocked by yosiat/panko_serializer#166

@skateman skateman force-pushed the rails-8 branch 2 times, most recently from 4142916 to 93e643d Compare November 15, 2024 10:31
@skateman skateman force-pushed the rails-8 branch 4 times, most recently from 09c2809 to 2b55488 Compare December 16, 2024 09:33
@vkrizan
Copy link
Collaborator

vkrizan commented Dec 16, 2024

This is great news!

@skateman panko just released a fixed version.

Are there any other breaking changes?

@skateman
Copy link
Member Author

LOL yes, Rails 8 support 😆

Copy link
Contributor

@RoamingNoMaD RoamingNoMaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty David <3

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (255b56c) to head (268994f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2309   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         200      200           
  Lines        4454     4454           
=======================================
  Hits         4376     4376           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skateman skateman merged commit 8b53099 into RedHatInsights:master Dec 18, 2024
13 checks passed
@skateman skateman deleted the rails-8 branch December 18, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants