-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): remove global test scheduler #7258
Conversation
This is great, @tmair ... it looks like there's a conflict though. |
410e651
to
f97ef76
Compare
|
@@ -1,15 +1,14 @@ | |||
/** @prettier */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this is the last PR where we have this line included. Can we update .prettierrc.json
and completely remove "overrides"
filed from it? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakovljevic-mladen I created a draft PR that removes the pragma and the spec
directory from the prettier formatting override. Please have a look at #7275. If we would like to merge those changes I can update the PR and promote it to a proper PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we would like to merge those changes I can update the PR and promote it to a proper PR.
I think we do. Great @tmair, thanks a bunch!
Thank you so much, @tmair ! |
Description:
This PR removes the global
rxTestScheduler
from the test infrastructure. To get this working it was necessary to also remove the tests for the global test scheduler.In addition the custom mocha UI was also removed because it is no loger necessary.