repeat: tests and fixes #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 19, 2015 15:45
Add tests for subscription/unsubscription moments of the repeatable source for the repeat operator. Resolves issue ReactiveX#554.
Fix repeat operator to unsubscribe from the repeatable source as soon as possible (when the previous repetition was completed), not when the resulting Observable was unsubscribed (which is as late as possible). Also fix repeat operator to not subscribe to the source at all if count=0. Resolves ReactiveX#554.
|
Coveralls is not happy because of -0.002% difference 😒 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #554.