Simplify test script pipeline #2851
Conversation
Generated by 🚫 dangerJS |
-+12.4KB-red.svg?style=flat-square){kind=icon}
-+2.5KB-red.svg?style=flat-square){kind=icon}
kwonoj
force-pushed
the
chore-simplify-test
branch
4 times, most recently
from
04bc96a to
da5105b
Compare
|
@benlesh for reviewing. Mostly it doesn't touch functionality but also it touches huge number of files. |
|
This looks great OJ, I'll try to pull this down and run it locally before I merge it very soon. |
kwonoj
force-pushed
the
chore-simplify-test
branch
from
18d3e59 to
6564101
Compare
|
Apologies, @kwonoj, I dropped the ball on looking at this. We might want to wait until the 5.5 version is released and then come back to this, as the packaging/building scripts are in a little bit of flux right now. |
|
I'm fine with that, feel freely to do so. |
|
Okay... so this looks okay... however a 4% drop in code coverage is HUGE. We should look into that before proceeding. |
kwonoj
force-pushed
the
chore-simplify-test
branch
2 times, most recently
from
4501f52 to
3fb35c5
Compare
kwonoj
force-pushed
the
chore-simplify-test
branch
4 times, most recently
from
42006bd to
2a29515
Compare
kwonoj
force-pushed
the
chore-simplify-test
branch
from
2a29515 to
be20525
Compare
kwonoj
force-pushed
the
chore-simplify-test
branch
2 times, most recently
from
721f8eb to
7443a88
Compare
kwonoj
force-pushed
the
chore-simplify-test
branch
2 times, most recently
from
a4fe70d to
2e29e1e
Compare
kwonoj
force-pushed
the
chore-simplify-test
branch
from
2e29e1e to
8d137ac
Compare
|
@benlesh it's good now, it was just glob wasn't smart enough to pick all test files. coverage change is within the threshold. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
This PR fixes #2850, also revises current build pipeline around unit tests. Our test setup is quite complex, by using compiled output from src for importing modules, then build each (src, spec) separately to run test cases. This also causes coverage remapping tricky, as recent change caused.
Instead, PR changes test cases to require sources directly - then run compile just once for specs and create coverage as well. It get rid of few npm scripts for testing purpose only, performance wise doesn't have much differences.
Few caveat is it requires to update some other scripts like doc generation but it can be dealt with seperately.
Related issue (if exists):