Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicast lacks overload #4451

Closed
Austaras opened this issue Jan 5, 2019 · 0 comments
Closed

Multicast lacks overload #4451

Austaras opened this issue Jan 5, 2019 · 0 comments

Comments

@Austaras
Copy link

Austaras commented Jan 5, 2019 •
edited
Loading

Bug Report

Current Behavior
multicast operator lacks following typing

export declare function multicast<T>(subject: Subject<T>, selector?: MonoTypeOperatorFunction<T>): MonoTypeOperatorFunction<T>;

Expected behavior

multicast(new Subject<number>, sub => sub)

should compile

Environment

  • Runtime: typescript 3.2.2
  • RxJS version: 6

Possible Solution
add this overload
@Austaras Austaras changed the title Multicast lack overload Multicast lacks overload Jan 5, 2019
cartant added a commit to cartant/rxjs that referenced this issue Jan 6, 2019
@cartant
chore(typings): fix dtslint tests
ef9cc3d 
Closes ReactiveX#4451
@cartant cartant mentioned this issue Jan 6, 2019
Merged
@benlesh benlesh closed this as completed in ebfb11a Jan 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Austaras