Skip to content

Commit

Permalink
chore: update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
benlesh committed Aug 26, 2020
1 parent a9dd55a commit c9ea2b0
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/internal/Observable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,8 @@ export class Observable<T> implements Subscribable<T> {
if (canReportError(sink)) {
sink.error(err);
} else {
// This is hit when the user develops a poorly made observable. That means that
// something is calling `subscriber.error` more than once. We're currently logging
// this as a warning to console to let them know something is wrong.
// TODO: Remove this in favor of some sort of reporting handle.
// If an error is thrown during subscribe, but our subscriber is closed, so we cannot notify via the
// subscription "error" channel, we are warning the developer of the problem here, via the console.
console.warn(err);
}
}
Expand Down

0 comments on commit c9ea2b0

Please sign in to comment.