Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Gradle Wrapper Validation GitHub Action #6848

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

JLLeitschuh
Copy link
Contributor

@JLLeitschuh JLLeitschuh commented Jan 15, 2020

As one of the most popular JVM projects on GitHub, this security measure aims to help protect your users from supply chain attacks.

See: https://github.com/gradle/wrapper-validation-action

@akarnokd
Copy link
Member

How is this supposed to work? I don't see any output regarding the validation in the CI log.

@JLLeitschuh
Copy link
Contributor Author

Hi @akarnokd,

You won't see it because your master branch doesn't have any existing GitHub Actions. As soon as you do, this will show up just like the Travis CI status checks.

Here's an example of what a failure would look like.
image (5) (5)

@akarnokd akarnokd merged commit 148eeb0 into ReactiveX:3.x Jan 15, 2020
@akarnokd
Copy link
Member

Thanks!

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #6848 into 3.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6848      +/-   ##
============================================
+ Coverage     98.25%   98.26%   +<.01%     
- Complexity     6380     6381       +1     
============================================
  Files           715      715              
  Lines         46522    46522              
  Branches       6387     6387              
============================================
+ Hits          45711    45715       +4     
- Misses          287      288       +1     
+ Partials        524      519       -5
Impacted Files Coverage Δ Complexity Δ
...al/operators/observable/ObservableSampleTimed.java 98.33% <0%> (-1.67%) 3% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 90.14% <0%> (-1.41%) 2% <0%> (ø)
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...ava3/internal/operators/parallel/ParallelJoin.java 92.04% <0%> (-1.14%) 3% <0%> (ø)
...java3/internal/operators/flowable/FlowableZip.java 97.39% <0%> (-1.05%) 6% <0%> (ø)
...3/internal/operators/flowable/FlowableGroupBy.java 95.59% <0%> (-0.95%) 3% <0%> (ø)
...a3/internal/operators/flowable/FlowableReplay.java 91.99% <0%> (-0.83%) 19% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.44% <0%> (-0.59%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-0.54%) 5% <0%> (ø)
...rxjava3/internal/schedulers/ExecutorScheduler.java 96.34% <0%> (-0.46%) 10% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fec1c7...5e3e280. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants