Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip, SkipLast, Take, TakeLast with time #655

Closed
wants to merge 3 commits into from

Conversation

akarnokd
Copy link
Member

Issue #653

@akarnokd akarnokd mentioned this pull request Dec 23, 2013
25 tasks
@cloudbees-pull-request-builder

RxJava-pull-requests #588 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

RxJava-pull-requests #589 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

RxJava-pull-requests #592 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

What is the reason for the drain concept? I know it exists in .Net but I don't believe we need this in Java.

I can imagine concern with not wanting a Timer thread to do long-running work, but we don't have that issue with our Scheduler implementations. We always have the time aspects of our schedulers running on separate threads (such as GenericScheduledExecutorService in the case of NewThreadScheduler so we don't block time events.

@akarnokd
Copy link
Member Author

I think it was added to avoid scheduling onNext calls individually but rather emit everything in one go. I haven't found any other places where this kind of overload was present in Rx.NET. Should I remove that overload? Are the other variants okay to stay?

@akarnokd
Copy link
Member Author

I'll resubmit this since it conflicts with master anyway.

@akarnokd akarnokd closed this Dec 23, 2013
@akarnokd akarnokd deleted the SkipNTakeWithTimespan branch January 13, 2014 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants