Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: remove getValues() from some subjects/processors #6516

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jun 19, 2019

The getValue() and getValues(T[]) methods were a remnant from a time where Subject and FlowableProcessor was unifying all state peeking methods for every kind of subject/processor. These have been marked as @Deprecated in 2.x and are now removed from 3.x. They can be trivially replaced with getValue() if necessary, for example:

Object value = subject.getValue();
if (value == null) {
   return new Object[1];
}
return new Object[] { value };

Related: #5622

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (3.x@cb03724). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             3.x    #6516   +/-   ##
======================================
  Coverage       ?   98.19%           
  Complexity     ?     6259           
======================================
  Files          ?      675           
  Lines          ?    45107           
  Branches       ?     6226           
======================================
  Hits           ?    44293           
  Misses         ?      280           
  Partials       ?      534
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/subjects/AsyncSubject.java 98.93% <ø> (ø) 45 <0> (?)
...n/java/io/reactivex/processors/AsyncProcessor.java 98.95% <ø> (ø) 45 <0> (?)
...ava/io/reactivex/processors/BehaviorProcessor.java 95.6% <ø> (ø) 50 <0> (?)
...in/java/io/reactivex/subjects/BehaviorSubject.java 98.8% <ø> (ø) 45 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb03724...58d4ac5. Read the comment docs.

@akarnokd akarnokd merged commit 40087e9 into ReactiveX:3.x Jun 19, 2019
@akarnokd akarnokd deleted the SubjectGetValuesRemoval branch June 19, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant