Remove unnecessary generic type parameters for delaySubscription methods in Single #5511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue with using the
delaySubscription(long time, TimeUnit unit)
while testing aSingle
and I saw that theU
generic type parameter was there unnecessarily. I believe this is only a Kotlin specific issue as I tried playing around in Java and there was no inference error upon compilation. To get it to compile for Kotlin, I would need to specify the generic type parameter and it didn't matter what I set it to asAny
was a valid option:.delaySubscription<Any>(5, TimeUnit.SECONDS)
. I also went throughFlowable
,Observable
, andMaybe
and saw that the generics were missing for the time-specificdelaySubscription
methods so I believe they should be removed fromSingle
as well to help keep things consistent and remove this compilation error for future Kotlin users.