-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: fix time bounded replaySubject getValue() inconsistency with getValues() on old items #5434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The build may need several restart as currently it either times out or gets killed by the container for some reason.
Codecov Report
@@ Coverage Diff @@
## 2.x #5434 +/- ##
============================================
+ Coverage 96.02% 96.07% +0.05%
- Complexity 5787 5801 +14
============================================
Files 631 631
Lines 41291 41297 +6
Branches 5742 5744 +2
============================================
+ Hits 39648 39678 +30
+ Misses 650 634 -16
+ Partials 993 985 -8
Continue to review full report at Codecov.
|
See #5433.