Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: cleanup for text and javadoc 04/15 #5286

Merged
merged 1 commit into from
Apr 15, 2017
Merged

Conversation

akarnokd
Copy link
Member

This PR

  • fixes a couple of documentation and message copy-paste errors
  • fixed FlowableFlattenIterable not checking for null returned by Iterator::next()
  • replace publisher with the appropriate name

@akarnokd akarnokd added this to the 2.0 backlog milestone Apr 15, 2017
@codecov
Copy link

codecov bot commented Apr 15, 2017

Codecov Report

Merging #5286 into 2.x will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5286      +/-   ##
============================================
- Coverage     96.13%   96.11%   -0.02%     
- Complexity     5748     5755       +7     
============================================
  Files           628      628              
  Lines         41077    41077              
  Branches       5699     5699              
============================================
- Hits          39488    39481       -7     
- Misses          621      626       +5     
- Partials        968      970       +2
Impacted Files Coverage Δ Complexity Δ
...o/reactivex/observables/ConnectableObservable.java 100% <ø> (ø) 7 <0> (ø) ⬇️
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 168 <0> (ø) ⬇️
.../java/io/reactivex/subjects/SerializedSubject.java 95.78% <ø> (ø) 27 <0> (ø) ⬇️
...rators/observable/ObservableBlockingSubscribe.java 96.96% <ø> (ø) 9 <0> (ø) ⬇️
...al/operators/flowable/FlowableFlattenIterable.java 97.24% <100%> (ø) 4 <0> (ø) ⬇️
...s/observable/ObservableBufferBoundarySupplier.java 90.67% <100%> (ø) 2 <0> (ø) ⬇️
...internal/operators/observable/ObservableDefer.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...perators/observable/ObservableMapNotification.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...ernal/operators/observable/ObservableDebounce.java 94.87% <100%> (ø) 2 <0> (ø) ⬇️
...in/java/io/reactivex/subjects/BehaviorSubject.java 84.89% <0%> (-5.73%) 56% <0%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e0ea5...631134c. Read the comment docs.

@akarnokd akarnokd merged commit 434d1f4 into ReactiveX:2.x Apr 15, 2017
@akarnokd akarnokd deleted the Cleanup0415 branch April 15, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants