Enhance test specifications and support classes for testing read models #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
condron
changed the title
condron
force-pushed
the
condron-mock-store-dispose-gaurds
branch
2 times, most recently
from
e0fed2d to
0cdb193
Compare
joshkempner
reviewed
Jun 24, 2024
src/ReactiveDomain.Testing/EventStore/MockStreamStoreConnection.cs
Outdated
Show resolved
Hide resolved
joshkempner
reviewed
Jun 24, 2024
condron
changed the title
condron
force-pushed
the
condron-mock-store-dispose-gaurds
branch
from
459e103 to
73503d8
Compare
joshkempner
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Overall I like the approach a lot.
Some small things:
- We should put XML comments on the new public classes & their public and protected methods/properties. I can help with that effort if necessary.
- We had discussed moving
ReadModelPropertyintoReactiveDomain.Testing. Is there a reason to avoid doing that in this PR, or did it just slip through the cracks?
|
Moving read model property triggers a shit storm of dependency changes and ties things to windows only versions |
|
Yes on the xml comments, help would be appreciated |
OK, I'll work on it this afternoon. |
condron
force-pushed
the
condron-mock-store-dispose-gaurds
branch
3 times, most recently
from
0e2988d to
8dcc755
Compare
joshkempner
force-pushed
the
condron-mock-store-dispose-gaurds
branch
from
e45631b to
4fd9694
Compare
condron
force-pushed
the
condron-mock-store-dispose-gaurds
branch
from
4fd9694 to
c74f21c
Compare
condron
force-pushed
the
condron-mock-store-dispose-gaurds
branch
from
c74f21c to
c805db9
Compare
condron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test specifications and support classes for ReadModel testing