Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support indexed rules in @call_rule macro #218

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Conversation

bvdmitri
Copy link
Member

This PR fixes #216

@albertpod
Copy link
Member

Some checks aren't successfull

@bvdmitri
Copy link
Member Author

To be honest I'm not entirely sure why does the CI fail. Locally everything works as expected and there were no changes related to the failing tests.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Base: 76.83% // Head: 76.72% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (1757d35) compared to base (7ca6e18).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   76.83%   76.72%   -0.12%     
==========================================
  Files         203      203              
  Lines        6712     6723      +11     
==========================================
+ Hits         5157     5158       +1     
- Misses       1555     1565      +10     
Impacted Files Coverage Δ
src/rule.jl 53.29% <20.00%> (-1.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bvdmitri
Copy link
Member Author

@albertpod tests have been fixed

@bvdmitri bvdmitri merged commit aa8a2ad into master Sep 30, 2022
@bvdmitri bvdmitri deleted the develop-issue-216 branch September 30, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test rules macro fails with indexed rules
3 participants