-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manifold for Categorical distribution #15
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 96.09% 96.59% +0.49%
==========================================
Files 22 24 +2
Lines 282 323 +41
==========================================
+ Hits 271 312 +41
Misses 11 11 ☔ View full report in Codecov by Sentry. |
…egorical feat: add SinglePointManifold
…entialFamilyManifolds.jl into categorical_manifold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Nimrais & @ismailsenoz ! LGTM, but the CI is failing....
Yeah, I found a bug in my implementation of the SinglePointManifold.jl while playing with projections, I will fix it and I will ping you. |
Yeah to really make this manifold useful, we need to first have this fixed ReactiveBayes/ExponentialFamily.jl#202. Because kinda the most crucial thing of this package ability to cast a point on manifold into distribution does not work. |
@Nimrais the fix for ReactiveBayes/ExponentialFamily.jl#202 has been released |
Thanks I will finish the PR then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.