Merge pull request #2 from ReactiveBayes/chisq-domain

Chisq domain is wrong
ReactiveBayes · Jun 17, 2024 · 0338617 · 0338617
2 parents eb880d7 + 1b955ec
commit 0338617
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -15,7 +15,7 @@ Static = "aedffcd0-7271-4cad-89d0-dc628f76c6d3"
 
 [compat]
 BayesBase = "1.3"
-ExponentialFamily = "1.4"
+ExponentialFamily = "1.4.3"
 LinearAlgebra = "1.10"
 Manifolds = "0.9"
 ManifoldsBase = "0.15"

diff --git a/src/natural_manifolds/chisq.jl b/src/natural_manifolds/chisq.jl
@@ -5,7 +5,7 @@
 Get the natural manifold base for the `Chisq` distribution.
 """
 function get_natural_manifold_base(::Type{Chisq}, ::Tuple{}, conditioner=nothing)
-    return ShiftedPositiveNumbers(static(-1//2))
+    return ShiftedPositiveNumbers(static(-1))
 end
 
 """

diff --git a/test/natural_manifolds/chisq_tests.jl b/test/natural_manifolds/chisq_tests.jl
@@ -2,6 +2,6 @@
     include("natural_manifolds_setuptests.jl")
 
     test_natural_manifold() do rng
-        return Chisq(1 + 10rand(rng))
+        return Chisq(10rand(rng))
     end
 end