List all errors in each database test before failing #1550
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
+ Coverage 41.84% 41.86% +0.01%
==========================================
Files 165 165
Lines 28010 28010
Branches 5714 5714
==========================================
+ Hits 11721 11726 +5
+ Misses 15500 15496 -4
+ Partials 789 788 -1
Continue to review full report at Codecov.
|
|
|
||
| boo = False | ||
| for item in tst: | ||
| if item[0] != item[1]: |
There was a problem hiding this comment.
For all of these tests, my initial thought is that the check should occur when you're iterating through the entries, and you should just store a list of error messages that need to be printed. Then at the end (here), if the list is not empty, log all of the stored messages and fail the test.
It seems cleaner that way. Let me know what you think.
|
Just a note that this commit may have made its way into master via the rmg-cat merge, as it had previously been cherry-picked onto the cat branch. |
|
Closing because this was merged into master with #1537. |
Since the database tests take a while to run this makes it much easier to debug database related issues.
Check that each test is unlikely to give a false pass and run the database tests to ensure there aren't any false fails.
Fixes #1549