fix(GmsCore support): Adjust presentation of battery optimization dialog #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since nobody can find any evidence that changing battery optimization for GmsCore increases the battery usage of YouTube, maybe the prompt message should be changed from: to something like: Edit: Additional text was added |
LisoUseInAIKyrios
force-pushed
the
fix/gmscore_no_alert_icon
branch
from
6f37901 to
819ea92
Compare
LisoUseInAIKyrios
changed the title
|
"will not negatively affect" might be better. However adding this text may trigger placebos in people trying to confirm whether it's true. |
|
I think it's better with the disclaimer than without. Some people see "disable battery optimizations" and they think the change applies to the entire phone or to YouTube. |
|
It could be even more generic and not even mention YouTube: "Disabling battery optimizations for MicroG will not negatively affect your device." Edit: Changed to this |
LisoUseInAIKyrios
force-pushed
the
fix/gmscore_no_alert_icon
branch
from
c4e6d75 to
bb9bfe4
Compare
…e harder to fix background mode problem on some devices.
LisoUseInAIKyrios
force-pushed
the
fix/gmscore_no_alert_icon
branch
from
bb9bfe4 to
d7046d5
Compare
oSumAtrIX
reviewed
Dec 10, 2024
oSumAtrIX
approved these changes
Dec 10, 2024
Co-authored-by: oSumAtrIX <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
# [5.4.0-dev.7](v5.4.0-dev.6...v5.4.0-dev.7) (2024-12-10) ### Bug Fixes * **GmsCore support:** Adjust presentation of battery optimization dialog ([#4091](#4091)) ([5d8fc1b](5d8fc1b))
github-actions bot
pushed a commit
that referenced
this pull request
Dec 14, 2024
# [5.4.0](v5.3.0...v5.4.0) (2024-12-14) ### Bug Fixes * **GmsCore support:** Adjust presentation of battery optimization dialog ([#4091](#4091)) ([5d8fc1b](5d8fc1b)) * **TikTok - Settings:** Use correct colors for dark mode ([#4087](#4087)) ([6bd22ff](6bd22ff)) * **TikTok - SIM Spoof:** Change patch to default off to fix login ([#4084](#4084)) ([f4659a3](f4659a3)) * **YouTube - Hide ads:** Hide new type of featured promotions ([#4113](#4113)) ([13c7592](13c7592)) * **YouTube - Spoof video streams:** Fix error toast that is sometimes shown ([#4090](#4090)) ([4c46cb2](4c46cb2)) * **YouTube - Spoof video streams:** Resolve playback of age restricted videos ([#4096](#4096)) ([839a404](839a404)) * **YouTube Music - Bypass certificate checks:** Add a recommended target version ([#4104](#4104)) ([17a5a6c](17a5a6c)) * **YouTube Music - Spoof video streams:** Disable stable volume ([#4097](#4097)) ([16bb9df](16bb9df)) ### Features * Add Internal data documents provider patch ([#3830](#3830)) ([cb22f65](cb22f65)) * **Change package name:** Add options to change provider and permission package names to handle installation conflicts ([75c740c](75c740c)) * **Twitch:** Make patches compatible with latest versions ([#4099](#4099)) ([eecfbb7](eecfbb7)) * **YouTube - Comments:** Add `Hide 'Chat summary'` ([#4110](#4110)) ([269493c](269493c))
github-actions bot
pushed a commit
to Flat/revanced-patches
that referenced
this pull request
Jan 15, 2025
# [5.3.0](v5.2.0...v5.3.0) (2025-01-15) ### Bug Fixes * **Change package name:** Prevent applying the patch to known incompatible apps ([ReVanced#3943](https://github.com/Flat/revanced-patches/issues/3943)) ([44936e7](44936e7)) * **ci:** update url for publishing ([a08568b](a08568b)) * **GmsCore support:** Adjust presentation of battery optimization dialog ([ReVanced#4091](https://github.com/Flat/revanced-patches/issues/4091)) ([5d8fc1b](5d8fc1b)) * **GmsCore support:** Do not show battery optimization error on Android Automotive devices (Google built-in) ([ReVanced#4218](https://github.com/Flat/revanced-patches/issues/4218)) ([d6e389c](d6e389c)) * **Reddit:** Fix patches by using correct extension class ([70bdc68](70bdc68)) * **Sync for Reddit:** Fix patches by using correct extension name ([030093e](030093e)) * **TikTok - Settings:** Use correct colors for dark mode ([ReVanced#4087](https://github.com/Flat/revanced-patches/issues/4087)) ([6bd22ff](6bd22ff)) * **TikTok - SIM Spoof:** Change patch to default off to fix login ([ReVanced#4084](https://github.com/Flat/revanced-patches/issues/4084)) ([f4659a3](f4659a3)) * **Twitch:** Change recommended target to the latest app version ([fb32972](fb32972)) * **Twitch:** Resolve setting menu crashes ([ReVanced#4025](https://github.com/Flat/revanced-patches/issues/4025)) ([62df596](62df596)) * **Twitter - Change link sharing domain:** Use correct extension package ([ad7fab6](ad7fab6)) * **twitter:** doubleclick ads ([c32fe2e](c32fe2e)) * **Twitter:** Merge correct extension by depending on correct extension patch ([8281cf6](8281cf6)) * **YouTube - Exit fullscreen mode:** Exit fullscreen mode of first video opened after cold start ([be5cf2e](be5cf2e)) * **YouTube - Force original audio:** If stream spoofing to Android then show a summary text why force audio is not available ([ReVanced#4220](https://github.com/Flat/revanced-patches/issues/4220)) ([029aee8](029aee8)) * **YouTube - Force original audio:** Use correct availability for settings UI ([a7eedcb](a7eedcb)) * **YouTube - Force original audio:** Use correct original audio stream if app language is not English ([0d20171](0d20171)) * **YouTube - Hide ads:** Hide new type of featured promotions ([ReVanced#4113](https://github.com/Flat/revanced-patches/issues/4113)) ([13c7592](13c7592)) * **YouTube - Hide layout components:** Don't hide Shorts channel bar when toggling for video player ([9af6412](9af6412)) * **YouTube - Hide layout components:** Hide new kind of community post ([ReVanced#4155](https://github.com/Flat/revanced-patches/issues/4155)) ([08f68cb](08f68cb)) * **YouTube - Miniplayer:** Use estimated maximum on screen size for devices with low density screens ([ReVanced#4150](https://github.com/Flat/revanced-patches/issues/4150)) ([2694158](2694158)) * **YouTube - Open Shorts in regular player:** Do not show the miniplayer after opening a Short while a video is playing ([894e366](894e366)) * **YouTube - SponsorBlock:** Show a toast and not a dialog if segment submitted successfully ([134b189](134b189)) * **YouTube - SponsorBlock:** Show create new segment error messages using a dialog ([ReVanced#4148](https://github.com/Flat/revanced-patches/issues/4148)) ([5870906](5870906)) * **YouTube - Spoof app version:** Update spoof target to resolve library tab crashes ([ReVanced#4014](https://github.com/Flat/revanced-patches/issues/4014)) ([c8eced5](c8eced5)) * **YouTube - Spoof app version:** Update spoof target to resolve library tab crashes ([ReVanced#4019](https://github.com/Flat/revanced-patches/issues/4019)) ([d89ad65](d89ad65)) * **YouTube - Spoof video stream:** Remove UI client type setting. Allow setting default audio language. ([ReVanced#4184](https://github.com/Flat/revanced-patches/issues/4184)) ([99f3f29](99f3f29)) * **YouTube - Spoof video streams:** Add 'Android Creator' ([ReVanced#4262](https://github.com/Flat/revanced-patches/issues/4262)) ([0479dd2](0479dd2)) * **YouTube - Spoof video streams:** Add iOS TV client, restore iOS 'force AVC', show client type in stats for nerds ([ReVanced#4202](https://github.com/Flat/revanced-patches/issues/4202)) ([ab29f80](ab29f80)) * **YouTube - Spoof video streams:** Add missing preferred language preference to the settings ([630633c](630633c)) * **YouTube - Spoof video streams:** Change default spoofing to iOS, allow setting a default language with Android VR ([ReVanced#4171](https://github.com/Flat/revanced-patches/issues/4171)) ([171b4e7](171b4e7)) * **YouTube - Spoof video streams:** Enable opus codec by updating iOS client version ([ReVanced#4063](https://github.com/Flat/revanced-patches/issues/4063)) ([0af156f](0af156f)) * **YouTube - Spoof video streams:** Fix error toast that is sometimes shown ([ReVanced#4090](https://github.com/Flat/revanced-patches/issues/4090)) ([4c46cb2](4c46cb2)) * **YouTube - Spoof video streams:** Ignore harmless error toast if hide ads is disabled ([c3423bb](c3423bb)) * **YouTube - Spoof video streams:** Make livestreams start at the current time when using iOS client ([ReVanced#4137](https://github.com/Flat/revanced-patches/issues/4137)) ([140f484](140f484)) * **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([ReVanced#4180](https://github.com/Flat/revanced-patches/issues/4180)) ([86abfb2](86abfb2)) * **YouTube - Spoof video streams:** Resolve playback of age restricted videos ([ReVanced#4096](https://github.com/Flat/revanced-patches/issues/4096)) ([839a404](839a404)) * **YouTube - Spoof video streams:** Update `Force AVC` client data ([ReVanced#4064](https://github.com/Flat/revanced-patches/issues/4064)) ([7d537dd](7d537dd)) * **YouTube - Spoof video streams:** Update iOS client version ([df3aeed](df3aeed)) * **YouTube - Spoof video streams:** Use 2 letter device language code ([33ff997](33ff997)) * **YouTube - Spoof video streams:** Use Android VR authentication if using default audio language ([ReVanced#4191](https://github.com/Flat/revanced-patches/issues/4191)) ([98773cc](98773cc)) * **YouTube - Spoof video streams:** Use system language as default iOS audio stream ([ReVanced#4042](https://github.com/Flat/revanced-patches/issues/4042)) ([4017185](4017185)) * **YouTube - Theme:** Use dark theme color for status and navigation bar ([0240efe](0240efe)) * **YouTube Music - Bypass certificate checks:** Add a recommended target version ([ReVanced#4104](https://github.com/Flat/revanced-patches/issues/4104)) ([17a5a6c](17a5a6c)) * **YouTube Music - GmsCore support:** Resolve patching errors ([ReVanced#4056](https://github.com/Flat/revanced-patches/issues/4056)) ([38a4bad](38a4bad)) * **YouTube Music - Hide category bar:** Add support for latest release ([ReVanced#3968](https://github.com/Flat/revanced-patches/issues/3968)) ([b63fdeb](b63fdeb)) * **YouTube Music - Permanent shuffle:** Remove obsolete and non functional patch ([ReVanced#4073](https://github.com/Flat/revanced-patches/issues/4073)) ([fbc6ab6](fbc6ab6)) * **YouTube Music - Spoof video streams:** Disable stable volume ([ReVanced#4097](https://github.com/Flat/revanced-patches/issues/4097)) ([16bb9df](16bb9df)) * **YouTube Music:** Add `Spoof client patch` to fix playback ([ReVanced#4132](https://github.com/Flat/revanced-patches/issues/4132)) ([b092508](b092508)) * **YouTube:** Change fingerprints to support a wider range of target versions ([8a09174](8a09174)) * **YouTube:** Do not reset playback speed to 1.0x after closing comment thread (Fixes stock YouTube bug) ([ReVanced#4195](https://github.com/Flat/revanced-patches/issues/4195)) ([dda788c](dda788c)) * **YouTube:** Fix string translations ([52e04d3](52e04d3)) ### Features * Add Internal data documents provider patch ([ReVanced#3830](https://github.com/Flat/revanced-patches/issues/3830)) ([cb22f65](cb22f65)) * **Change package name:** Add options to change provider and permission package names to handle installation conflicts ([75c740c](75c740c)) * **Nyx:** Remove broken `Unlock pro` patch ([1fe8b16](1fe8b16)) * **Swipe controls:** Add option to enable/disable fullscreen swipe to next video ([ReVanced#4222](https://github.com/Flat/revanced-patches/issues/4222)) ([119092f](119092f)) * **Twitch:** Make patches compatible with latest versions ([ReVanced#4099](https://github.com/Flat/revanced-patches/issues/4099)) ([eecfbb7](eecfbb7)) * **YouTube - Comments:** Add `Hide 'Chat summary'` ([ReVanced#4110](https://github.com/Flat/revanced-patches/issues/4110)) ([269493c](269493c)) * **YouTube - Hide feed components:** Remove obsolete `Hide search result shelf header` option ([ReVanced#4134](https://github.com/Flat/revanced-patches/issues/4134)) ([c71443a](c71443a)) * **YouTube - Hide Shorts components:** Add option to hide Shorts in watch history ([ReVanced#4214](https://github.com/Flat/revanced-patches/issues/4214)) ([19c2742](19c2742)) * **YouTube - Navigation buttons:** Add options to disable translucent status bar and navigation bar ([ReVanced#4133](https://github.com/Flat/revanced-patches/issues/4133)) ([a2d2141](a2d2141)) * **YouTube - Spoof app version:** Add 'Restore old navigation and toolbar icons' ([f84e459](f84e459)) * **YouTube - Spoof video streams:** Allow picking a default audio language track ([ReVanced#4050](https://github.com/Flat/revanced-patches/issues/4050)) ([ede666b](ede666b)) * **YouTube Music:** Add `Spoof video streams` patch to fix playback ([ReVanced#4065](https://github.com/Flat/revanced-patches/issues/4065)) ([cf3116a](cf3116a)) * **YouTube:** Add `Change form factor` patch ([ReVanced#4217](https://github.com/Flat/revanced-patches/issues/4217)) ([644ac5b](644ac5b)) * **YouTube:** Add `Exit fullscreen mode` patch ([ReVanced#4223](https://github.com/Flat/revanced-patches/issues/4223)) ([bb5d03b](bb5d03b)) * **YouTube:** Add `Force original audio` patch ([ReVanced#4122](https://github.com/Flat/revanced-patches/issues/4122)) ([f4aa440](f4aa440)) * **YouTube:** Add `Open Shorts in regular player` patch ([ReVanced#4153](https://github.com/Flat/revanced-patches/issues/4153)) ([c7c5e5b](c7c5e5b)) * **YouTube:** Add `Open videos fullscreen` patch ([ReVanced#4069](https://github.com/Flat/revanced-patches/issues/4069)) ([296d63b](296d63b)) * **YouTube:** Add in app option to select a preferred language for ReVanced specific text ([ReVanced#4231](https://github.com/Flat/revanced-patches/issues/4231)) ([3932af3](3932af3)) * **YouTube:** Support version `19.47.53` ([ReVanced#4182](https://github.com/Flat/revanced-patches/issues/4182)) ([2089e61](2089e61)) ### Performance Improvements * Move variables to local scope ([43c0421](43c0421))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the 'alert' icon that shows at the top of the dialog, which may be confused as an actual error or warning when this is a normal step on first installation.
Also rearranges the order of the battery optimization check so the easy to fix check is done first.