Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1706, library(data.table) fails if "Packaged" field is not pr… #1707

Merged

Conversation

restonslacker
Copy link
Contributor

…esent in DESCRIPTION

Recently, R seems to no longer add the "Packaged" field to DESCRIPTION when building from source. This prevents an end-user from loading the dev version because of the "staleness" check in onAttach(). However, "Built" is in there. This PR attempts to capture that and use it as a substitute. If that fails, it skips the rest of the check.

@codecov-io
Copy link

Current coverage is 90.61%

Merging #1707 into master will decrease coverage by <.01%

@@             master      #1707   diff @@
==========================================
  Files            55         55          
  Lines         10172      10178     +6   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           9221       9222     +1   
- Misses          951        956     +5   
  Partials          0          0          
  1. File src/forder.c (not in diff) was modified. more
    • Misses -1
    • Partials 0
    • Hits +1

Powered by Codecov. Last updated by cdeb472...a1cc6a7

…is not present in DESCRIPTION

alternate approach to this issue which avoids call to try()
@arunsrinivasan arunsrinivasan merged commit d9cf539 into Rdatatable:master May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants