Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check.names argument for setDT #1338

Closed
MichaelChirico opened this issue Sep 17, 2015 · 2 comments
Closed

check.names argument for setDT #1338

MichaelChirico opened this issue Sep 17, 2015 · 2 comments
Labels
feature request

Comments

@MichaelChirico
Copy link
Member

Given how simple implementing check.names seems to be, seems like setDT could go for the same argument.

Would allow my answer to this question to be done by reference, and in general would be key for when fread is not an option for bringing in outside data.
@arunsrinivasan
Copy link
Member

@MichaelChirico agreed. PR? Matt's working on pushing to CRAN at the moment. If you can get this done soon, we can get it on v1.9.6 :-).

@MichaelChirico
Copy link
Member Author

@arunsrinivasan ooh exciting. Was wondering when that might happen! I'm hoping to get it done at some point today.

arunsrinivasan added a commit that referenced this issue Sep 17, 2015
@arunsrinivasan
Merge pull request #1339 from MichaelChirico/setDTchk
85f7690 
Closes #1338: setDT gains check.names argument
arunsrinivasan added a commit that referenced this issue Sep 17, 2015
@arunsrinivasan
Fixed setDT.Rd, #1338.
2629931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arunsrinivasan @MichaelChirico