Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin sanic patch #5027

Merged
merged 1 commit into from
Jan 3, 2020
Merged

pin sanic patch #5027

merged 1 commit into from
Jan 3, 2020

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Jan 2, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@erohmensing erohmensing requested a review from tmbo January 2, 2020 12:42
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ⭐️

@tmbo tmbo merged commit 7c5a596 into 1.6.x Jan 3, 2020
@erohmensing erohmensing deleted the pin-sanic branch January 4, 2020 06:33
@@ -0,0 +1 @@
Pin sanic patch version instead of minor version. Fixes sanic ``_run_request_middleware()`` error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erohmensing this should be in changelog/ not in the root dir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ach, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants